Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update .browserslistrc #2384

Merged
merged 1 commit into from
Aug 26, 2021
Merged

[core] Update .browserslistrc #2384

merged 1 commit into from
Aug 26, 2021

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Aug 18, 2021

Based on this PR mui/material-ui#27788

@DanailH DanailH added the core Infrastructure work going on behind the scenes label Aug 18, 2021
@DanailH DanailH self-assigned this Aug 18, 2021
oliviertassinari
oliviertassinari approved these changes Aug 21, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we build with TypeScript here, and the builder doesn't handle the browserlist file, these changes have almost no impacts (it's a different story in the main repository).

@flaviendelangle
Copy link
Member

Couldn't we use the file from the core ?

In package.json

  "browserslist": [
    "extends @material-ui/monorepo/.browserslistrc"
  ],

@DanailH
Copy link
Member Author

DanailH commented Aug 23, 2021

Since we build with TypeScript here, and the builder doesn't handle the browserlist file, these changes have almost no impacts (it's a different story in the main repository).

Should we then just ignore the changes and close the PR?

@DanailH DanailH changed the base branch from master to next August 26, 2021 09:32
@DanailH DanailH merged commit 32d03f9 into mui:next Aug 26, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 5, 2021 •
edited
Loading

Couldn't we use the file from the core ?

@flaviendelangle It seems supported /~https://github.com/browserslist/browserslist#shareable-configs but I wonder. If we intend to cover multiple versions of the core, we might have to compile with the older versions of the browsers?

@LukasTy LukasTy mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees

@DanailH DanailH

Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanailH @flaviendelangle @oliviertassinari