-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Trigger row spanning computation on rows update #15858
Conversation
Deploy preview: https://deploy-preview-15858--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the after preview, after clicking couple of times, the rows are back, but they are combined anymore
Thank you @arminmeh for pointing it out. There were two issues.
Updated the demo and it seems to be working now. |
Cherry-pick PRs will be created targeting branches: v7.x |
Hi team, I came across this thread and believe I'm experiencing a similar issue. When updating rows in the DataGrid, the row spanning computation doesn't seem to re-trigger if the index-based range remains unchanged. I've recorded a short video showing the behavior. Could you please help confirm if this is the same issue as reported in #15819 and fixed in #15858? Thank you for your assistance! Recording.2025-01-04.010645-VEED.mp4 |
Hey @kashyap-cephei |
Fixes #15819
Addresses a corner case, whenever rows get updated and the (index based)
range
doesn't change, it results in skipping the necessary re-computation of row spanning state.