[charts] Fix scatter dataset with missing data #15802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
bug 🐛
|
Deploy preview: https://deploy-preview-15802--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #15802 will not alter performanceComparing Summary
|
JCQuintas
approved these changes
Dec 9, 2024
|
Cherry-pick PRs will be created targeting branches: v7.x |
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15801
I hesitated to keep
undefinedvalues to be able to distinguishundefinedandnull.But a scatter point where either x or y is not defined is impossible to represent
If you're ok with the fix I will add a test to prevent future regression