Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Clear timers on unmount #15620

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[DataGrid] Clear timers on unmount #15620

merged 1 commit into from
Nov 26, 2024

Conversation

cherniavskii
Copy link
Member

Suggestion reported in #15459 (comment)

@cherniavskii cherniavskii added performance component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Nov 26, 2024
@cherniavskii cherniavskii requested a review from a team November 26, 2024 15:01
@mui-bot
Copy link

mui-bot commented Nov 26, 2024

Deploy preview: https://deploy-preview-15620--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c2e4e83

romgrk
romgrk reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I read the source of throttle(), I see that it doesn't handle timeouts like useTimeout does, we should probably also fix that. Or maybe add a useThrottle if it's used frequently enough, we could encapsulate the cleanup logic in there.

@cherniavskii cherniavskii merged commit aa7f984 into mui:master Nov 26, 2024
26 checks passed
@cherniavskii cherniavskii deleted the clear-timers-on-unmount branch November 26, 2024 19:31
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
@cherniavskii @web-flow
[DataGrid] Clear timers on unmount (#15620)
0520bbf
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Merged
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@cherniavskii @LukasTy
[DataGrid] Clear timers on unmount (mui#15620)
3c83989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk left review comments

@KenanYusuf KenanYusuf KenanYusuf approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge performance v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherniavskii @mui-bot @romgrk @KenanYusuf