[docs] Use loading state in the demos #15512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
docs
|
Deploy preview: https://deploy-preview-15512--material-ui-x.netlify.app/ |
KenanYusuf
approved these changes
Nov 20, 2024
|
I still can't really see the loading state on my machine, but when I slow down the CPU through devtools it's noticeable. |
@KenanYusuf Even on page refresh? Screen.Recording.2024-11-20.at.17.59.19.mov |
|
Aha, now I see the skeleton loader on refresh, same as your video. Looks good! |
cherniavskii
added
the
needs cherry-pick
cherniavskii
added a commit
to cherniavskii/mui-x
that referenced
this pull request
Nov 21, 2024
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes comment: /~https://github.com/mui/mui-x/pull/15504/files#r1850503158
I didn't update demos with less than 100 rows since the loading state is too short.