Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix version tooltip #15468

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

alexfauquette
Copy link
Member

Currently

image

After PR

image

@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Nov 18, 2024
@mui-bot
Copy link

mui-bot commented Nov 18, 2024

Deploy preview: https://deploy-preview-15468--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d8fc8c1

@@ -232,7 +232,7 @@ function AppWrapper(props) {
metadata: '',
name: 'MUI X',
versions: [
...getVersionOptions('introduction', ['next', process.env.LIB_VERSION, 'v6', 'v5']),
...getVersionOptions('introduction', [process.env.LIB_VERSION, 'v7', 'v6', 'v5']),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the logic needs to change a bit for the pre-release phase. 🤔
current using a relative URL should be the v7, while the version === process.env.LIB_VERSION should point to next.mui.com

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. This PR will be merged on master will only impact the next.mui.com

So when version === process.env.LIB_VERSION it means we are on next.mui.com and so we can just link to /x/.... to stay on next

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair point... 🙈
But what about v7.mui.com?
Are we going to create this and redirect to mui.com?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I added a edge case for v7

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@alexfauquette alexfauquette enabled auto-merge (squash) November 18, 2024 15:54
@alexfauquette alexfauquette merged commit 3d25ecc into mui:master Nov 18, 2024
16 checks passed
alexfauquette added a commit that referenced this pull request Nov 19, 2024
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants