-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Fix version tooltip #15468
Conversation
Deploy preview: https://deploy-preview-15468--material-ui-x.netlify.app/ |
@@ -232,7 +232,7 @@ function AppWrapper(props) { | |||
metadata: '', | |||
name: 'MUI X', | |||
versions: [ | |||
...getVersionOptions('introduction', ['next', process.env.LIB_VERSION, 'v6', 'v5']), | |||
...getVersionOptions('introduction', [process.env.LIB_VERSION, 'v7', 'v6', 'v5']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the logic needs to change a bit for the pre-release phase. 🤔
current
using a relative URL should be the v7
, while the version === process.env.LIB_VERSION
should point to next.mui.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it. This PR will be merged on master will only impact the next.mui.com
So when version === process.env.LIB_VERSION
it means we are on next.mui.com
and so we can just link to /x/....
to stay on next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fair point... 🙈
But what about v7.mui.com
?
Are we going to create this and redirect to mui.com
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I added a edge case for v7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Currently
After PR