-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Maximum update depth exceeded - MUI Datagrid when renderCell is in columns #15721
Comments
The reproduction steps are insufficient ... What do you need to do with the app when its running in prod mode? Also, when looking at your code I noticed that the only thing you do in renderCell is to return a constructed value. You can simply do this with a - renderCell: (row) => {
+ valueGetter: (_value, row) => {
const prioridade =
row.row.nivel_prioridade.split("")[0].toUpperCase() +
row.row.nivel_prioridade.slice(1);
return prioridade;
}, |
One of our users was experiencing this as well (on Chrome only, it worked on Microsoft edge). I was not able to reproduce it myself, and our other users weren't. It was resolved when I rolled back the DataGrid version to 7.22.1. The error looked like it was coming from a dimensions issue. We do also use renderCell in several columns, in cases where valueGetter is insufficient to render the cell.
|
All right ... since this is a highly customized implementation I would first suggest a bug in that, but you can never be too sure! :D The problem is that we cannot do anything if we have no reproduction case. If you can provide one that would be great ... IMHO it's not related to the app being a production build though. |
Just chiming in to say I'm seeing the same error since upgrading. I will try to create a reproduction case and share. But it seems an odd coincidence, and there is no other change in the code on our side, so I suspect something may have snuck in within MUI... Bear with me and I'll try to share a case later today. |
So I have just recreated it locally with this code:
From eliminating various parameters. The flex parameter on the column seems to be the culprit? |
I'm finding the same issue
This example fails:
The following makes it work:
This same code has been running quite happily in previous versions. |
We also have a flex value on our columns:
|
Ok, seems as if this affects quite a few users. |
Tried to replicate using @pauljonesnz code here #15721 (comment) https://codesandbox.io/p/sandbox/silly-microservice-7qv2n3 I've used the same code on a fresh install and ran the production build locally, not seeing the error. Is someone able to provide a CodeSandbox/StackBlitz reproduction? |
@KenanYusuf, I opened your link and it showed the error. If I remove "flex: 1" it works normally. |
Well this is strange. Screen.Recording.2024-12-06.at.18.28.58.mov@mui/xgrid is codesandbox.io/p/sandbox/silly-microservice-7qv2n3 erroring for anyone? |
Try testing in windows. |
Hi All Code Sandbox doesn't reproduce the error. It is an odd one alright. Fine on Edge, not on Chrome - except NOTE that it works on Code Sandbox for both. |
When attempting an upgrade to 7.23 last week, I saw the same max update depth exceeded error but:
I haven't spent any time on getting a minimal reproduction yet though. Also, the code sandbox link above doesn't crash for me. |
Thanks for the details. Unfortunately, I haven't been able to reproduce this yet. Can I ask that those experiencing the issue drop a comment with their environment details? You can run |
Yes sure- System: The npm package here doesn't include the updated x-data-grid - but that upgrade would be the only thing I change to cause the issue. I use Vivaldi as my main browser, but as it's Chromium I assume no difference from Chrome... |
System: |
Not sure why it can't find my Chrome version - it is: 131.0.6778.86 System: |
I encountered the same problem using @mui/x-data-grid-premium version 7.23.0 that appears to be related to using a 4K monitor. The data grid renders correctly when I move the browser window to my 1080p monitor and refresh the page, but it fails to render properly on the 4K monitor. @mui/x-data-grid-premium version: 7.23.0 System: |
Thanks everyone for the environment details. I have managed to reproduce the error on Windows 11, Chrome 131: Screen.Recording.2024-12-10.at.14.54.32.movWorking on a fix. Edit: I've traced the resize issue shown in the video back to ba6c7a1, which was released back in v7.10.0. Makes me think there is more than one way to encounter this bug, given how many people are reporting it now. Will try and reproduce it again with the original CodeSandbox from @ArturLimaSS |
We were experiencing a similar issue in Chrome, but not in Edge, after updating to v7.23.0. What helped us resolve the issue was deleting all time browsing data in Chrome. Maybe this helps some of you guys facing similar issue. |
I think this regression was introduced in #15549 and released in /~https://github.com/mui/mui-x/releases/tag/v7.23.0 |
We're using 7.22.3 without any issue. As soon a we go to 7.23.1 it happens
…On Thu, 12 Dec 2024, 05:22 Andrew Cherniavskii, ***@***.***> wrote:
I've traced the resize issue shown in the video back to ba6c7a1
<ba6c7a1>,
which was released back in v7.10.0
I think this regression was introduced in #15549
<#15549> and released in
/~https://github.com/mui/mui-x/releases/tag/v7.23.0
v7.22.0 seems to work fine:
https://codesandbox.io/p/sandbox/15850-before-forked-sj4f8p?file=%2Fpackage.json
—
Reply to this email directly, view it on GitHub
<#15721 (comment)>, or
unsubscribe
</~https://github.com/notifications/unsubscribe-auth/ABILHSZMQMPIFL3ZAPLDCIL2FBRDHAVCNFSM6AAAAABS6KJKN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZWGQ2TQOJZGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
If anyone needs more information, in my case the bug manifests when the page is sufficiently wide. The following situations prevent the bug from manifesting:
And another stacktrace:
|
@pauljonesnz @KenanYusuf @cherniavskii @michelengelen to get the CodeSandbox example that was posted in this thread to manifest the error, try to zoom out the browser window, then hit the refresh button in the sandbox. |
This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. Note @ArturLimaSS How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey. |
Steps to reproduce
Steps:
Current behavior
I just didn't understand the error. When I render a button with renderCell. In development, some cases that I didn't understand give the error, in production, it never works.
Expected behavior
It should render the options when using the renderOptions option, as it always has.
Context
No response
Your environment
npx @mui/envinfo
Search keywords: Datagrid renderCell Maximum Update Depth exceeded
The text was updated successfully, but these errors were encountered: