Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix links in CONTRIBUTING.md #45202

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[docs] Fix links in CONTRIBUTING.md #45202

merged 2 commits into from
Feb 4, 2025

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Feb 4, 2025 •
edited
Loading

Fix two links in CONTRIBUTING.md:

  1. The "Checks and how to fix them" section seems to have been renamed to "CI checks and how to fix them", which broke the link in the markdown file;
  2. The link that "behind its target branch" points to seems to have disappeared and now redirects to GitHub's Community Discussions. In this case, I've opted to link to GitHub's docs about keeping a PR in sync with its base branch. Feel free to suggest a better link if you know one

@mui-bot
Copy link

mui-bot commented Feb 4, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-45202--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0d40da7

@bernardobelchior
Copy link
Member Author

CC @mapache-salvaje

@bernardobelchior bernardobelchior added the docs Improvements or additions to the documentation label Feb 4, 2025
mapache-salvaje
mapache-salvaje approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bernardobelchior bernardobelchior merged commit 1fb6063 into mui:master Feb 4, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapache-salvaje mapache-salvaje mapache-salvaje approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernardobelchior @mui-bot @mapache-salvaje