[material-ui][IconButton] Set default loading to null
#45057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: icon button
siriwatknp
commented
Jan 20, 2025
Comment on lines
+219
to
+226
| {typeof loading === 'boolean' && ( | ||
| // use plain HTML span to minimize the runtime overhead | ||
| <span className={classes.loadingWrapper} style={{ display: 'contents' }}> | ||
| <IconButtonLoadingIndicator className={classes.loadingIndicator} ownerState={ownerState}> | ||
| {loading && loadingIndicator} | ||
| </IconButtonLoadingIndicator> | ||
| </span> | ||
| )} |
There was a problem hiding this comment.
Do the same as Button
38 tasks
Netlify deploy previewhttps://deploy-preview-45057--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Added a test to check that no element is rendered when I don't think it's worth to test the loading wrapper as it's an implementation detail. The progressbar test is already enough. |
aarongarciah
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45048