Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][ListItem] Add codemod for deprecated props #45022

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jan 14, 2025

@sai6855 sai6855 added component: list This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material labels Jan 14, 2025
@sai6855 sai6855 requested a review from siriwatknp January 14, 2025 08:03
@mui-bot
Copy link

mui-bot commented Jan 14, 2025

Netlify deploy preview

https://deploy-preview-45022--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c8d09c5

@siriwatknp
Copy link
Member

@sai6855 The PR looks good.

The ListItem needs a refinement. The slots.secondaryAction is missing.

@sai6855
Copy link
Contributor Author

sai6855 commented Jan 15, 2025

Okay, I'll try to add in seperate PR

@sai6855 sai6855 merged commit a6c44ba into mui:master Jan 15, 2025
19 checks passed
@sai6855
Copy link
Contributor Author

sai6855 commented Jan 15, 2025

The ListItem needs a refinement. The slots.secondaryAction is missing.

@siriwatknp Do we need to deprecate secondaryAction prop as well, if slots.secondaryAction is added ?

docs for prop: https://mui.com/material-ui/api/list-item/#list-item-prop-secondaryAction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants