[joy-ui][docs] Fix Color mode button on Theme builder #44864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
changed the title
aarongarciah
added
docs
aarongarciah
changed the title
aarongarciah
changed the title
aarongarciah
force-pushed
the
fix-theme-builder-toggle-mode
branch
from
e3fc9e1 to
e9a363a
Compare
Netlify deploy previewhttps://deploy-preview-44864--material-ui.netlify.app/ Bundle size report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error on the client-side when clicking the same color on the Theme builder page.
Screen.Recording.2567-12-27.at.10.47.44.mov
Before
There is an error when clicking the same color on the Theme builder page.
Screen.Recording.2567-12-27.at.10.29.34.mov
After
Set color mode only when
newValueis not null.Screen.Recording.2567-12-27.at.10.28.52.mov