Support 10.0.18363.836: Has no IVirtualDesktopManagerInternal2 manager
#39
Conversation
…nager `raise NotImplementedError` on `.name` and `.rename` methods. Fixes mrob95#37 Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
|
@stdedos where do I need to catch |
|
Sadly, @totaam, I do not have a more concrete response for you than "Whenever you'd call an instance of The code that you are highlighting only iterates (and returns) all the available monitors of the system. It should be a safe call. Also note that the project sprinkles a lot of It might not interest you directly, but I have tried to prototype a def safe_operation(fallback_value=None, log_error=True):
"""
A decorator to safely execute operations and handle exceptions.
:param fallback_value: The value to return in case of an exception.
:param log_error: Whether to log the error or not.
"""
def decorator(func):
@functools.wraps(func)
def wrapper(*args, **kwargs):
try:
return func(*args, **kwargs)
except Exception as e:
if log_error:
logging.error(f"Error during {func.__name__}: {e}")
return fallback_value
return wrapper
return decoratorI didn't have concrete goals for it, so it's on a YMMV-basis. On a tangent from this MR, your Xpra-org/xpra@778067d is correct: I'd suggest re-packing XPRA after this is merged Also note that I tried to be a little bit more audible for dangerous operations: But it's not like this is Java code; upstream might also not like it either. |
|
lgtm, thanks 👍 |
|
Released in |
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Fixup #39: `@property` doesn't have a `.__name__` property itself
raise NotImplementedErroron.nameand.renamemethods.Fixes #37
Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com