Error: There is already a Construct with name 'TypeScriptSource' in BucketDeployment

[george-hm]

Describe the bug
When adding multiple sources (e.g. 2 TypescriptSource's) to a BucketDeployment construct, there is an error:

Error: There is already a Construct with name 'TypeScriptSource' in BucketDeployment

To Reproduce
Create two TypescriptSource's (or two JavaScriptSource, the error happens for either) and add them to a bucket deployment
Example:

const sourceOne = new TypeScriptSource('sourceOne.ts', {
    buildOptions: {
        outfile: 'sourceOne.js',
    },
});
const sourceTwo = new TypeScriptSource('sourceTwo.ts', {
    buildOptions: {
        outfile: 'sourceTwo.js',
    },
});

new BucketDeployment(this, 'EmbedassetsDeployment', {
    destinationBucket: myBucket,
    sources: [
        sourceOne,
        sourceTwo,
    ],
});

Expected behavior
No error and able to deploy successfully

Versions:

• CDK: ^2.41.0
• Node.js: v18.18.2

Additional context
I believe this issue stems from the consistent ID set for creating a new s3Asset which is done here:
/~https://github.com/mrgrain/cdk-esbuild/blob/v5/src/source.ts#L69

It would be good if this ID is generated based on something so it is more unique

Looking at the full stacktrace hints at this problem:

Error: There is already a Construct with name 'TypeScriptSource' in BucketDeployment [EmbedassetsDeployment]
    at Node.addChild (/redacted/node_modules/constructs/src/construct.ts:403:13)
    at new Node (/redacted/node_modules/constructs/src/construct.ts:71:17)
    at new Construct (/redacted/node_modules/constructs/src/construct.ts:463:17)
    at new Asset (/redacted/node_modules/aws-cdk-lib/aws-s3-assets/lib/asset.js:1:473)
    at new EsbuildAsset (/redacted/node_modules/@mrgrain/cdk-esbuild/src/asset.ts:104:5)
    at new TypeScriptAsset (/redacted/node_modules/@mrgrain/cdk-esbuild/src/asset.ts:135:1)
    at TypeScriptSource.bind (/redacted/node_modules/@mrgrain/cdk-esbuild/src/source.ts:76:20)
    at /redacted/node_modules/aws-cdk-lib/aws-s3-deployment/lib/bucket-deployment.js:1:2867
    at Array.map (<anonymous>)
    at new BucketDeployment (/redacted/node_modules/aws-cdk-lib/aws-s3-deployment/lib/bucket-deployment.js:1:2848)

[mrgrain]

Ah good catch!

[mrgrain]

Hey @george-hm Sorry this took so long. It's fixed in v5.0.8.
Fixes for v3 and v4 are coming as well, please LMK if you need these prioritized.

[george-hm]

@mrgrain no worries we were wrapping up for the holidays anyhow!

Thanks for the fix, we have upgraded to v5

[mrgrain]

Updating to v5 is great. It's also fixed for v3 and v4 now.