Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap symbols for PS5 Create and Options buttons #13

Merged
merged 7 commits into from
Jun 23, 2024
Merged

Swap symbols for PS5 Create and Options buttons #13

merged 7 commits into from
Jun 23, 2024

Conversation

benwilson34
Copy link
Contributor

Hi! Love these icons 👍 just wanted to make a small adjustment - the symbols on the PS5 Create and Options buttons seem to be swapped judging from the angle of the button outlines. The Create button is the left-leaning one and the Options button is the right-leaning one:
2024-06-18 10 49 15

Here's the change:
image

I've only changed the source svg file for now, let me know if all looks good and I can prepare the individual svg and png files. Thanks! 😁

@mr-breakfast
Copy link
Owner

I seem to have issues with PS5 prompts... #12

This looks great, thank you for making a fix!

To merge though, I'll need updates to

  • previews/preview.svg and previews/ps5_preview.svg (and then exports to png for both). This can be done by copy/pasting the new icons over the olds ones in the svg, and
  • the corresponding /png and /svg icons.

@benwilson34
Copy link
Contributor Author

Ok, I've updated all but the preview pngs. I'm missing the Megusto font so the "B" in "Mr. Breakfast" isn't quite right:
ps5_preview-temp

If that's the only place the font is used, could you convert that "B" to a path instead of text (like with the "M") so that Megusto isn't a dependency? I found some sites offering a free download of the font but I don't necessarily trust them.

@mr-breakfast
Copy link
Owner

mr-breakfast commented Jun 20, 2024 •
edited
Loading

Yes I can do that! /meta/center_title is a path version of the "Mr. Breakfast," but I'll go through main and make them paths

@mr-breakfast
Copy link
Owner

mr-breakfast commented Jun 20, 2024 •
edited
Loading

And thank you for your README copy edits and additions 😁

@mr-breakfast
Copy link
Owner

I mistakenly edited main and not this PR. Let me get that fixed. Sorry for the inconvenience

@mr-breakfast
Copy link
Owner

I mistakenly edited main and not this PR. Let me get that fixed. Sorry for the inconvenience

Done 👍

@mr-breakfast mr-breakfast merged commit eb11608 into mr-breakfast:main Jun 23, 2024
@mr-breakfast mr-breakfast added this to the Itch Package 2 milestone Jun 23, 2024
@benwilson34
Copy link
Contributor Author

Awesome, thank you!

mr-breakfast added a commit that referenced this pull request Jun 25, 2024
@mr-breakfast
Squashed commit of the following:
622828e 
commit ea2553f
Merge: eb11608 b32042a
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Mon Jun 24 08:58:30 2024 -0700

    Merge pull request #15 from lopopylopy/change-notes-expirement

    Convert CHANGE_NOTES to markdown file extension

commit b32042a
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Mon Jun 24 08:56:13 2024 -0700

    Update CHANGE_NOTES.md

commit f31bd0b
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Mon Jun 24 08:45:33 2024 -0700

    Rename CHANGE_NOTES to CHANGE_NOTES.md

commit eb11608
Merge: f3ee05c 213f767
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Sun Jun 23 11:56:45 2024 -0700

    Merge pull request #13 from benwilson34/main

    - Swap symbols for PS5 Create and Options buttons
    - copyedit README
    - make "Mr. Breakfast" path
    - add to CHANGE_NOTES

commit 213f767
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Sun Jun 23 11:52:09 2024 -0700

    update previews

commit db3b0df
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Sun Jun 23 11:06:26 2024 -0700

    make "Mr. Breakfast" paths and not text

commit f3ee05c
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Sun Jun 23 11:04:39 2024 -0700

    Revert "made preview "Mr. Breakfast" into path"

    This reverts commit 098f33c.

commit 098f33c
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Wed Jun 19 17:20:48 2024 -0700

    made preview "Mr. Breakfast" into path

commit 1944b3f
Author: Ben Wilson <ben.wilson1337@gmail.com>
Date:   Wed Jun 19 18:34:16 2024 -0400

    update readme

commit 126c6b7
Author: Ben Wilson <ben.wilson1337@gmail.com>
Date:   Wed Jun 19 18:01:45 2024 -0400

    update readme and change notes

commit aee5e67
Merge: 7731bee a695e99
Author: Ben Wilson <ben.wilson1337@gmail.com>
Date:   Wed Jun 19 17:50:51 2024 -0400

    Merge remote-tracking branch 'orig/main'

commit 7731bee
Author: Ben Wilson <ben.wilson1337@gmail.com>
Date:   Wed Jun 19 17:20:15 2024 -0400

    update preview svgs and individual prompt files

commit a695e99
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Tue Jun 18 18:57:08 2024 -0700

    create /meta to house README content

commit ba69a94
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Tue Jun 18 18:45:16 2024 -0700

    Update README.md

commit 3fc1409
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Tue Jun 18 18:43:17 2024 -0700

    Update README.md, add contributing guide

commit 9246e92
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Tue Jun 18 18:42:17 2024 -0700

    create `~/previews/src` to house preview svg

commit d67f4db
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Tue Jun 18 18:27:41 2024 -0700

    Create CHANGE_NOTES

commit f335631
Author: Ben Wilson <ben.wilson1337@gmail.com>
Date:   Tue Jun 18 10:45:10 2024 -0400

    swap icons for ps5 create and options buttons

commit 270fcfe
Merge: 6ef7190 991fee5
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Sat Jun 15 08:13:09 2024 -0700

    Merge pull request #11 from AdamGaskins/main

    Swap 1 and 2 in L1/L2/R1/R2 for PS5

commit 991fee5
Merge: c8c0382 9dbfb3c
Author: Adam Gaskins <adam@theadamgaskins.com>
Date:   Sat Jun 15 13:16:24 2024 +0900

    Merge branch 'main' of /~https://github.com/AdamGaskins/mrbreakfasts_free_prompts

commit c8c0382
Author: Adam Gaskins <adam@theadamgaskins.com>
Date:   Sat Jun 15 13:03:16 2024 +0900

    Fix ps5_l2_light.svg

commit 9dbfb3c
Author: Adam Gaskins <adam@theadamgaskins.com>
Date:   Sat Jun 15 12:48:06 2024 +0900

    Update images in README.md to use relative paths

commit 5ead406
Author: Adam Gaskins <adam@theadamgaskins.com>
Date:   Sat Jun 15 12:45:01 2024 +0900

    Swapped PS5's R1 and R2

commit 6ef7190
Author: Mr. Breakfast <65320586+lopopylopy@users.noreply.github.com>
Date:   Thu Feb 29 11:08:10 2024 -0700

    update image sourcing in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Itch Package 2
Development

Successfully merging this pull request may close these issues.
2 participants
@benwilson34 @mr-breakfast