-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset the cache-dir when a component is added to HscEnv #29
Conversation
This patch looks as I imagined it. We really need to refactor that 6-tuple into a record now! |
We discussed in IRC about what needs to happen for this patch to be finished.
|
Indeed and I am on it. |
63cfe4b
to
8f271dc
Compare
Right it does, but it might as well not as |
680c536
to
dd57aae
Compare
Additionally a prefix for the cache-dir: InstalledUnitId. Sort components for cache-dir so that order doesnt matter Also remove "executable" component dependencies as they are not important for interface files.
dd57aae
to
d674f29
Compare
Ready to merge, in my opinion. |
So the conclusion is it fixes some issues but there are still problems? |
for this pr, yes, but I will continue to venture into the problem on Cabal. |
Would be good if we could reproduce it on some smaller projects other than GHC and Cabal.. |
I will provide a minimal reproducible project. I have a good idea how to reproduce it. |
A pretty small example: /~https://github.com/fendor/ghcide-bad-interface-files |
Also, adds a prefix for the cache-dir: InstalledUnitId.
closes #15
closes #13