Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Break down ExperimentDetails container into (mostly) simple components #2807

Closed
johngruen opened this issue Aug 21, 2017 · 1 comment
Closed

Break down ExperimentDetails container into (mostly) simple components #2807

johngruen opened this issue Aug 21, 2017 · 1 comment
Assignees
@lmorchard
Milestone
Sprint 35 🇧🇲

Comments

@johngruen
Copy link
Contributor

In order to support the ongoing storybook work on the site, we should break down ExperimentPage Container into simple components.
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 14, 2017
@lmorchard
Initial work toward new component bundle directories
9e93a57 
- Moved ExperimentRowCard and UpdateList components into subdirectories

- Extracted IncompatibleAddons as a component from ExperimentPage

- Webpack config to extract static/app/app.js.css from component imports

- Storybook config changes to use frontend/src/app/**/{ComponentName}/stories.jsx files

- Mocha test command changes use frontend/src/app/**/{ComponentName}/tests.js

- Hacks to frontend/tasks/pages.js to ignore scss imports

- Hacks to test-setup.js to ignore scss imports

See also:
https://gist.github.com/chuckharmston/01e5b7a16ba9b771863cbb8b2de64138

Issue mozilla#2807
@lmorchard lmorchard mentioned this issue Sep 14, 2017
Merged
7 tasks
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 14, 2017
@lmorchard
Initial work toward new component bundle directories
5b9af0f 
- Moved ExperimentRowCard and UpdateList components into subdirectories

- Extracted IncompatibleAddons as a component from ExperimentPage

- Webpack config to extract static/app/app.js.css from component imports

- Storybook config changes to use frontend/src/app/**/{ComponentName}/stories.jsx files

- Mocha test command changes use frontend/src/app/**/{ComponentName}/tests.js

- Hacks to frontend/tasks/pages.js to ignore scss imports

- Hacks to test-setup.js to ignore scss imports

See also:
https://gist.github.com/chuckharmston/01e5b7a16ba9b771863cbb8b2de64138

Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 14, 2017
@lmorchard
Initial work toward new component bundle directories
9f3beda 
- Moved ExperimentRowCard and UpdateList components into subdirectories

- Extracted IncompatibleAddons as a component from ExperimentPage

- Webpack config to extract static/app/app.js.css from component imports

- Storybook config changes to use frontend/src/app/**/{ComponentName}/stories.jsx files

- Mocha test command changes use frontend/src/app/**/{ComponentName}/tests.js

- Hacks to frontend/tasks/pages.js to ignore scss imports

- Hacks to test-setup.js to ignore scss imports

See also:
https://gist.github.com/chuckharmston/01e5b7a16ba9b771863cbb8b2de64138

Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 15, 2017
@lmorchard
Tweaks to support component directory bundles
e73f2fe 
- Storybook now also finds stories in frontend/src/app/**/stories.js

- `npm run test` now also finds tests in frontend/src/app/**/tests.js

- New /static/app/app.js.css stylesheet built from Sass styles imported
  by components

- Hacks to ignore .scss imports when using component modules outside
  Webpack for static page build & tests

- Update flowconfig to ignore .scss imports

- Small eslint upgrade so CLI matches gulp-eslint

Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 15, 2017
@lmorchard
Reorganize ExperimentRowCard component into bundle directory
16b1aa4 
Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 15, 2017
@lmorchard
Reorganize UpdateList component into bundle directory
e289513 
Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 15, 2017
@lmorchard
Begin to extract IncompatibleAddons component from ExperimentPage con…
bd61781 
…tainer

Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 15, 2017
@lmorchard
Reorganize ExperimentRowCard component into bundle directory
4f8f0ed 
Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 15, 2017
@lmorchard
Reorganize UpdateList component into bundle directory
a164a96 
Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 15, 2017
@lmorchard
Begin to extract IncompatibleAddons component from ExperimentPage con…
ceaff1b 
…tainer

Issue mozilla#2807
@ghost ghost added this to the Sprint 32 milestone Sep 18, 2017
lmorchard added a commit that referenced this issue Sep 22, 2017
@lmorchard
Initial work toward new component bundle directories (#2859)
f4000e2 
* Tweaks to support component directory bundles

- Storybook now also finds stories in frontend/src/app/**/stories.js

- `npm run test` now also finds tests in frontend/src/app/**/tests.js

- New /static/app/app.js.css stylesheet built from Sass styles imported
  by components

- Hacks to ignore .scss imports when using component modules outside
  Webpack for static page build & tests

- Update flowconfig to ignore .scss imports

- Small eslint upgrade so CLI matches gulp-eslint

* Reorganize ExperimentRowCard component into bundle directory

* Reorganize UpdateList component into bundle directory

* Begin to extract IncompatibleAddons component from ExperimentPage container

* Rename stories.jsx -> stories.js; See also: airbnb/javascript#985 (comment)

* Quick & dirty revision to Storybook docs to incorporate new component bundle proposal

Issue #2807
@lmorchard lmorchard self-assigned this Sep 26, 2017
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 26, 2017
@lmorchard
Issue mozilla#2807: Move ExperimentPage container into a bundle direc…
79fb7ca 
…tory, move IncompatibleAddons subcomponent into the bundle
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 26, 2017
@lmorchard
Issue mozilla#2807: Move ExperimentPage tests into bundle directory
4b7a42e
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 27, 2017
@lmorchard
Issue mozilla#2807: Try extracting TestpilotPromo and adding flowtype…
0865608 
… annotations to MainInstallButton
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Try extracting TestpilotPromo and adding flowtype…
bc723e0 
… annotations to MainInstallButton
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Reorganize subcomponents & tests used only by Exp…
0235395 
…erimentPage
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: More ExperimentPage test lint fixes
26c4764
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Quick experiment install fix
7dec623
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Move ExperimentPage container into a bundle direc…
e07fd1c 
…tory, move IncompatibleAddons subcomponent into the bundle
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Move ExperimentPage tests into bundle directory
1287b6e
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Try extracting TestpilotPromo and adding flowtype…
29900cb 
… annotations to MainInstallButton
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Reorganize subcomponents & tests used only by Exp…
324bc18 
…erimentPage
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: More ExperimentPage test lint fixes
0bb0edf
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2017
@lmorchard
Issue mozilla#2807: Quick experiment install fix
09050ce
@ghost ghost modified the milestones: Sprint 32, Sprint 33 Oct 2, 2017
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 9, 2017
@lmorchard
Issue mozilla#2807: Move ExperimentPage container into a bundle direc…
6b7850e 
…tory, move IncompatibleAddons subcomponent into the bundle
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 9, 2017
@lmorchard
Issue mozilla#2807: Move ExperimentPage tests into bundle directory
bb57dc1
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 9, 2017
@lmorchard
Issue mozilla#2807: Try extracting TestpilotPromo and adding flowtype…
c2c004e 
… annotations to MainInstallButton
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 9, 2017
@lmorchard
Issue mozilla#2807: Reorganize subcomponents & tests used only by Exp…
47ba607 
…erimentPage
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 9, 2017
@lmorchard
Issue mozilla#2807: More ExperimentPage test lint fixes
5942609
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 9, 2017
@lmorchard
Issue mozilla#2807: Quick experiment install fix
dd6342d
meandavejustice pushed a commit that referenced this issue Oct 10, 2017
@lmorchard
Break down ExperimentDetails container into (mostly) simple components (
49435b6 
#2891)

* Quick linting fix for gulpfile

* Issue #2807: Move ExperimentPage container into a bundle directory, move IncompatibleAddons subcomponent into the bundle

* Issue #2807: Move ExperimentPage tests into bundle directory

* Fix linting errors in ExperimentPage tests

* Issue #2807: Try extracting TestpilotPromo and adding flowtype annotations to MainInstallButton

* Issue #2807: Reorganize subcomponents & tests used only by ExperimentPage

* Issue #2807: More ExperimentPage test lint fixes

* Issue #2807: Quick experiment install fix

* Ensure ExperimentPage-test.js is removed after rebase
@ghost ghost modified the milestones: Sprint 33, Sprint 34 Oct 11, 2017
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 23, 2017
@lmorchard
Issue mozilla#2807: Extract EolBlock
4f0d4fb
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 23, 2017
@lmorchard
Issue mozilla#2807: Progress toward extracting DetailsOverview and De…
ecbbee2 
…tailsDescription
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 24, 2017
@lmorchard
Issue mozilla#2807: Progress toward extracting DetailsOverview and De…
10e6f7f 
…tailsDescription
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 24, 2017
@lmorchard
Issue mozilla#2807: MORE PROGRESS
4bc69b3
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 25, 2017
@lmorchard
Issue mozilla#2807: Move privacyScrollOffset from state and into a co…
a983d55 
…nstant since it never changes; switch ExperimentPage to mount() from shallow() in tests; stop testing component state since it moved into subcomponents and markup should be enough to reflect functionality;
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 25, 2017
@lmorchard
Issue mozilla#2807: EVEN MORE PROGRESS
b94b3f4
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 26, 2017
@lmorchard
Issue mozilla#2807: Extract EolBlock
079b63f 
Issue mozilla#2807: Progress toward extracting DetailsOverview and DetailsDescription

PROGRESS

Issue mozilla#2807: MORE PROGRESS

Issue mozilla#2807: Move privacyScrollOffset from state and into a constant since it never changes; switch ExperimentPage to mount() from shallow() in tests; stop testing component state since it moved into subcomponents and markup should be enough to reflect functionality;

Issue mozilla#2807: EVEN MORE PROGRESS
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 26, 2017
@lmorchard
Issue mozilla#2807: Extract EolBlock
8a04cff 
Issue mozilla#2807: Progress toward extracting DetailsOverview and DetailsDescription

PROGRESS

Issue mozilla#2807: MORE PROGRESS

Issue mozilla#2807: Move privacyScrollOffset from state and into a constant since it never changes; switch ExperimentPage to mount() from shallow() in tests; stop testing component state since it moved into subcomponents and markup should be enough to reflect functionality;

Issue mozilla#2807: EVEN MORE PROGRESS
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 26, 2017
@lmorchard
Issue mozilla#2807: Extract EolBlock
d86999c 
Issue mozilla#2807: Progress toward extracting DetailsOverview and DetailsDescription

PROGRESS

Issue mozilla#2807: MORE PROGRESS

Issue mozilla#2807: Move privacyScrollOffset from state and into a constant since it never changes; switch ExperimentPage to mount() from shallow() in tests; stop testing component state since it moved into subcomponents and markup should be enough to reflect functionality;

Issue mozilla#2807: EVEN MORE PROGRESS
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 26, 2017
@lmorchard
Break ExperimentPage container into simpler sub-components
ed589f4 
- Extract DetailHeader, DetailOverview, and DetailDescription from
  ExperimentDetail component

- Add flow type annotations to ExperimentPage and new sub-components

- Subtitle related properties optional in Warning component

- Reformatted components with `prettier --single-quote`

- Move privacyScrollOffset from state and into a constant since it never changes

- Switch ExperimentPage tests from shallow() to mount() to test sub-components

- Stop testing component state since it moved into subcomponents and
  markup should be enough to reflect functionality

Issue mozilla#2807
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 26, 2017
@lmorchard
Break ExperimentPage container into simpler sub-components
3f18306 
- Extract DetailHeader, DetailOverview, and DetailDescription from
  ExperimentDetail component

- De-dupe measurements section into single component, repeated for
  responsive layout

- Add flow type annotations to ExperimentPage and new sub-components

- Subtitle related properties optional in Warning component

- Reformatted components with `prettier --single-quote`

- Move privacyScrollOffset from state and into a constant since it never changes

- Switch ExperimentPage tests from shallow() to mount() to test sub-components

- Stop testing component state since it moved into subcomponents and
  markup should be enough to reflect functionality

Issue mozilla#2807
@lmorchard lmorchard mentioned this issue Oct 26, 2017
Merged
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 31, 2017
@lmorchard
Break ExperimentPage container into simpler sub-components
e1c5ca0 
- Extract DetailHeader, DetailOverview, and DetailDescription from
  ExperimentDetail component

- De-dupe measurements section into single component, repeated for
  responsive layout

- Add flow type annotations to ExperimentPage and new sub-components

- Subtitle related properties optional in Warning component

- Reformatted components with `prettier --single-quote`

- Move privacyScrollOffset from state and into a constant since it never changes

- Switch ExperimentPage tests from shallow() to mount() to test sub-components

- Stop testing component state since it moved into subcomponents and
  markup should be enough to reflect functionality

Issue mozilla#2807
meandavejustice pushed a commit that referenced this issue Oct 31, 2017
@lmorchard
Break ExperimentPage container into simpler sub-components (#2990)
4898279 
- Extract DetailHeader, DetailOverview, and DetailDescription from
  ExperimentDetail component

- De-dupe measurements section into single component, repeated for
  responsive layout

- Add flow type annotations to ExperimentPage and new sub-components

- Subtitle related properties optional in Warning component

- Reformatted components with `prettier --single-quote`

- Move privacyScrollOffset from state and into a constant since it never changes

- Switch ExperimentPage tests from shallow() to mount() to test sub-components

- Stop testing component state since it moved into subcomponents and
  markup should be enough to reflect functionality

Issue #2807
@lmorchard
Copy link
Contributor

PR #2990 has been merged, so let's call this one finally done and open new issues for anything further that needs doing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmorchard lmorchard

Labels
None yet
Projects
None yet
Milestone
Sprint 35 🇧🇲
Development

No branches or pull requests
2 participants
@lmorchard @johngruen