Reduce, now unnecessary, asynchronicity in the BasePreferences constructor
#12630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/811d270a51575d6/output.txt |
…tructor Originally the default preferences were defined in a JSON-file checked into the repository, which was loaded using SystemJS in development mode. Over the years a number of changes have been made to this code, most notably: - The preferences JSON-file is now generated automatically, during building, from the `AppOptions` abstraction. - All SystemJS usage has been removed from the development viewer. Hence the default preferences are now available *synchronously* even in the development viewer, and it's thus no longer necessary to defer to the microtask queue (since `getDefaultPreferences` is async) just to get the default preferences. While the effect of these changes is quite small, it *does* reduces the time it takes for the preferences to be fully initialized. Given the amount of asynchronous code during viewer initialization, every bit of time that we can save should thus help.
Snuffleupagus
force-pushed
the
BasePreferences-less-async
branch
from
29cf1b2 to
7adcb90
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/811d270a51575d6/output.txt Total script time: 4.05 mins Published |
timvandermeij
approved these changes
Nov 16, 2020
|
Nice simplification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the default preferences were defined in a JSON-file checked into the repository, which was loaded using SystemJS in development mode.
Over the years a number of changes have been made to this code, most notably:
AppOptionsabstraction.Hence the default preferences are now available synchronously even in the development viewer, and it's thus no longer necessary to defer to the microtask queue (since
getDefaultPreferencesis async) just to get the default preferences.While the effect of these changes is quite small, it does reduces the time it takes for the preferences to be fully initialized. Given the amount of asynchronous code during viewer initialization, every bit of time that we can save should thus help.
Smaller/simpler diff with /~https://github.com/mozilla/pdf.js/pull/12630/files?w=1