Some hasJSActions, and general annotation-code, related cleanup in the viewer and API
#12622
Conversation
…the viewer and API - Add support for logical assignment operators, i.e. `&&=`, `||=`, and `??=`, with a Babel-plugin. Given that these required incrementing the ECMAScript version in the ESLint and Acorn configurations, and that platform/browser support is still fairly limited, always transpiling them seems appropriate for now. - Cache the `hasJSActions` promise in the API, similar to the existing `getAnnotations` caching. With this implemented, the lookup should now be cheap enough that it can be called unconditionally in the viewer. - Slightly improve cleanup of resources when destroying the `WorkerTransport`. - Remove the `annotationStorage`-property from the `PDFPageView` constructor, since it's not necessary and also brings it more inline with the `BaseViewer`. - Update the `BaseViewer.createAnnotationLayerBuilder` method to actaually agree with the `IPDFAnnotationLayerFactory` interface.[1] - Slightly tweak a couple of JSDoc comments. --- [1] We probably ought to re-factor both the `IPDFTextLayerFactory` and `IPDFAnnotationLayerFactory` interfaces to take parameter objects instead, since especially the `IPDFAnnotationLayerFactory` one is becoming quite unwieldy. Given that that would likely be a breaking change for any custom viewer-components implementation, this probably requires careful deprecation.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/904e975ead9cf2e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/904e975ead9cf2e/output.txt Total script time: 4.13 mins Published |
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6728317f0b07f38/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/be7bf0ba5b36742/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/6728317f0b07f38/output.txt Total script time: 3.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/be7bf0ba5b36742/output.txt Total script time: 4.65 mins
|
|
Thank you for doing this! |
Add support for logical assignment operators, i.e.
&&=,||=, and??=, with a Babel-plugin. Given that these required incrementing the ECMAScript version in the ESLint and Acorn configurations, and that platform/browser support is still fairly limited, always transpiling them seems appropriate for now.Cache the
hasJSActionspromise in the API, similar to the existinggetAnnotationscaching. With this implemented, the lookup should now be cheap enough that it can be called unconditionally in the viewer.Slightly improve cleanup of resources when destroying the
WorkerTransport.Remove the
annotationStorage-property from thePDFPageViewconstructor, since it's not necessary and also brings it more inline with theBaseViewer.Update the
BaseViewer.createAnnotationLayerBuildermethod to actaually agree with theIPDFAnnotationLayerFactoryinterface.[1]Slightly tweak a couple of JSDoc comments.
[1] We probably ought to re-factor both the
IPDFTextLayerFactoryandIPDFAnnotationLayerFactoryinterfaces to take parameter objects instead, since especially theIPDFAnnotationLayerFactoryone is becoming quite unwieldy. Given that that would likely be a breaking change for any custom viewer-components implementation, this probably requires careful deprecation.