-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix *some* errors reported by the ESLint no-useless-escape
rule
#12551
Conversation
This patch removes unnecessary escape-sequence in (mostly) strings, as a first step, since the ones in regular expressions probably requires more careful testing (just in case). The only exception is a regular expression in `src/core/annotation.js`, since we should have both unit- and reference-tests for this code *and* given [this information on MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Character_Classes#Types): > Inside a character set, the dot loses its special meaning and matches a literal dot. Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-useless-escape
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/81a11b38919f576/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/71f617f5ae32406/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/81a11b38919f576/output.txt Total script time: 2.38 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/71f617f5ae32406/output.txt Total script time: 3.09 mins
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/9426f1c861cbdda/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/223a8bb73fe0938/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/223a8bb73fe0938/output.txt Total script time: 25.44 mins
Image differences available at: http://54.67.70.0:8877/223a8bb73fe0938/reftest-analyzer.html#web=eq.log |
Thanks! |
This patch removes unnecessary escape-sequence in (mostly) strings, as a first step, since the ones in regular expressions probably requires more careful testing (just in case).
The only exception is a regular expression in
src/core/annotation.js
, since we should have both unit- and reference-tests for this code and given this information on MDN:Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-useless-escape