Use a Map, rather than an Object, internally in the Catalog.openAction getter (PR 11644 follow-up)
#12543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Action` getter (PR 11644 follow-up) This provides a work-around to avoid having to conditionally try to initialize the `openAction`-object in multiple places. Given that `Object.fromEntries` doesn't seem to *guarantee* that a `null` prototype is used, we thus hack around that by using `Object.assign` with `Object.create(null)`.
…ototype is used Given that `Object.fromEntries` doesn't seem to *guarantee* that a `null` prototype is used, we thus hack around that by using `Object.assign` with `Object.create(null)`.
Snuffleupagus
force-pushed
the
openActionMap
branch
from
0961ef8 to
820fb7f
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9ab37fc453b6606/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9ab37fc453b6606/output.txt Total script time: 3.46 mins
|
timvandermeij
approved these changes
Oct 28, 2020
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a work-around to avoid having to conditionally try to initialize the
openAction-object in multiple places; this indirectly fixes #11644 (comment).Given that
Object.fromEntriesdoesn't seem to guarantee that anullprototype is used, we thus hack around that by usingObject.assignwithObject.create(null).