In a text widget, Font resources can be in the appearance #12394
Conversation
|
Is there test coverage for this or should a test be added? The file itself is already included in /~https://github.com/mozilla/pdf.js/pull/12393/files, but do we need a print test here? |
|
I can add a test. |
|
Looks good to me with a reference test added. Most likely this can be done in the same way as in /~https://github.com/mozilla/pdf.js/pull/12361/files. |
calixteman
force-pushed
the
appearance
branch
from
93630c5 to
98ea09f
Compare
|
@calixteman If you have time, could you address the comments in this and the other PRs so we can get some of them merged? |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eaa5bcf5a3dc169/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a7078e0daadc28f/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/a7078e0daadc28f/output.txt Total script time: 29.27 mins
Image differences available at: http://54.215.176.217:8877/a7078e0daadc28f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/eaa5bcf5a3dc169/output.txt Total script time: 60.00 mins |
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8cfc0d9c27a2e41/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8cfc0d9c27a2e41/output.txt Total script time: 27.15 mins
Image differences available at: http://54.67.70.0:8877/8cfc0d9c27a2e41/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7925fa282cf52d6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7925fa282cf52d6/output.txt Total script time: 3.53 mins Published |
|
Opening the |
|
In order to see the "effect" of this patch on file |
|
Could you rebase this one now that #12292 is merged so we can also look into landing this one? |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/f41ec1825ca802d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8fb2522fd1c7bac/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8fb2522fd1c7bac/output.txt Total script time: 26.15 mins
Image differences available at: http://54.67.70.0:8877/8fb2522fd1c7bac/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/f41ec1825ca802d/output.txt Total script time: 27.91 mins
Image differences available at: http://3.101.106.178:8877/f41ec1825ca802d/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2b246a0196b352d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2b246a0196b352d/output.txt Total script time: 4.05 mins Published |
|
Thank you for fixing this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c35a407fe19cfe8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/2fba89365b6e5a7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c35a407fe19cfe8/output.txt Total script time: 24.76 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/2fba89365b6e5a7/output.txt Total script time: 26.33 mins
|
In file /~https://github.com/mozilla/pdf.js/files/5249872/product1.pdf, the fifth text widget has a default appearance using font F1 and this one is neither in DR nor in AcroForm but in AP::N::Resources.
Fixes #12398.