Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore spaces when normalizing the font name in Font.fallbackToSystemFont (issue 11578) #11579

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #11578

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a245bc8dbbec868/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/54ada35ebca05da/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/a245bc8dbbec868/output.txt

Total script time: 19.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/a245bc8dbbec868/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/54ada35ebca05da/output.txt

Total script time: 26.28 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/54ada35ebca05da/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2020

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0fb3194df5e5c8e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/0fb3194df5e5c8e/output.txt

Total script time: 1.74 mins

Published

@timvandermeij timvandermeij merged commit dced0a3 into mozilla:master Feb 9, 2020
@timvandermeij
Copy link
Contributor

Nice find! (makeref also for the other PR)

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2020

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/cc8070da8e97be7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2020

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 2

Live output at: http://54.215.176.217:8877/f305543a99ba7fa/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/cc8070da8e97be7/output.txt

Total script time: 18.13 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/f305543a99ba7fa/output.txt

Total script time: 24.07 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-11578 branch February 9, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect character rendering
3 participants