Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent circular references in the /Pages tree #11577

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/dbb5a54ebac822b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/25ccff25b08eae7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/dbb5a54ebac822b/output.txt

Total script time: 19.62 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/dbb5a54ebac822b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2020

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/25ccff25b08eae7/output.txt

Total script time: 26.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/25ccff25b08eae7/reftest-analyzer.html#web=eq.log

@Rob--W
Copy link
Member

Rob--W commented Feb 17, 2020

If I'm not mistaken, this looks like something that could reasonably easily be covered by a unit test. Could you update the PR with a unit test?

@Snuffleupagus
Copy link
Collaborator Author

Could you update the PR with a unit test?

While I already have a test-case locally, please note that I'd prefer to wait for @brendandahl to sign-off on that though.

Copy link
Contributor

@brendandahl brendandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, I'd also like to see a test case and the one comment addressed.

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/344b220015a17b7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/cfea372c2597501/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/cfea372c2597501/output.txt

Total script time: 2.13 mins

  • Font tests: FAILED
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/cfea372c2597501/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/344b220015a17b7/output.txt

Total script time: 19.55 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/344b220015a17b7/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-windows unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/376a5a0ba8905c3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/376a5a0ba8905c3/output.txt

Total script time: 4.67 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit e158601 into mozilla:master Feb 27, 2020
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the Pages-tree-refs branch February 28, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants