-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent circular references in the /Pages tree #11577
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dbb5a54ebac822b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/25ccff25b08eae7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/dbb5a54ebac822b/output.txt Total script time: 19.62 mins
Image differences available at: http://54.67.70.0:8877/dbb5a54ebac822b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/25ccff25b08eae7/output.txt Total script time: 26.20 mins
Image differences available at: http://54.215.176.217:8877/25ccff25b08eae7/reftest-analyzer.html#web=eq.log |
9337725
to
36345e4
Compare
If I'm not mistaken, this looks like something that could reasonably easily be covered by a unit test. Could you update the PR with a unit test? |
While I already have a test-case locally, please note that I'd prefer to wait for @brendandahl to sign-off on that though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, I'd also like to see a test case and the one comment addressed.
36345e4
to
3c7b7be
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/344b220015a17b7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cfea372c2597501/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/cfea372c2597501/output.txt Total script time: 2.13 mins
Image differences available at: http://54.215.176.217:8877/cfea372c2597501/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/344b220015a17b7/output.txt Total script time: 19.55 mins
Image differences available at: http://54.67.70.0:8877/344b220015a17b7/reftest-analyzer.html#web=eq.log |
/botio-windows unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/376a5a0ba8905c3/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/376a5a0ba8905c3/output.txt Total script time: 4.67 mins
|
Thank you! |
No description provided.