[Firefox] Slightly simplify how the generator is determined, when sending telemetry data from the viewer #11466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding telemetry data from the viewer When working on PR 11463 I couldn't help thinking that the `Array.prototype.some` callback function, used when determining the generator, was somewhat difficult to read with its partly unused and strangely named parameters.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/959b96885f82831/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/959b96885f82831/output.txt Total script time: 1.75 mins Published |
timvandermeij
approved these changes
Jan 6, 2020
|
Thank you! I also had to re-read this a few times before I understood the old code; the new one is indeed easier to read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on PR #11463 I couldn't help thinking that the
Array.prototype.somecallback function, used when determining the generator, was somewhat difficult to read with its partly unused and strangely named parameters.