-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtract stream.start
when getting the startXRef
property for documents with a Linearization dictionary (issue 11330)
#11335
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/243c1c79db34664/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/243c1c79db34664/output.txt Total script time: 1.72 mins Published |
…uments with a Linearization dictionary (issue 11330) For documents with a Linearization dictionary the computed `startXRef` position will be relative to the raw file, rather than the actual PDF document itself (which begins with `%PDF-`). Hence it's necessary to subtract `stream.start` in this case, since otherwise the `XRef.readXRef` method will increment the position too far resulting in parsing errors.
d148f89
to
9199b02
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/67715c3c1579f49/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/409650acdb5117f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/67715c3c1579f49/output.txt Total script time: 18.81 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/409650acdb5117f/output.txt Total script time: 26.64 mins
Image differences available at: http://54.215.176.217:8877/409650acdb5117f/reftest-analyzer.html#web=eq.log |
Nice find! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d76769a5aa6cd86/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/efbbb02ef933c3e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d76769a5aa6cd86/output.txt Total script time: 16.93 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/efbbb02ef933c3e/output.txt Total script time: 23.85 mins
|
For documents with a Linearization dictionary the computed
startXRef
position will be relative to the raw file, rather than the actual PDF document itself (which begins with%PDF-
).Hence it's necessary to subtract
stream.start
in this case, since otherwise theXRef.readXRef
method will increment the position too far resulting in parsing errors.Fixes #11330