Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Close #12538: Crash notification will always trigger the crash prompt dialog #12539

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Close #12538: Crash notification will always trigger the crash prompt dialog #12539

merged 2 commits into from
Aug 3, 2022

Conversation

rocketsroger
Copy link
Contributor

@rocketsroger rocketsroger commented Jul 22, 2022 •
edited by github-actions bot
Loading

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Fixes #12538

@rocketsroger rocketsroger added 🕵️‍♀️ needs review PRs that need to be reviewed do not land PRs that requires coordination before landing labels Jul 22, 2022
@rocketsroger
Copy link
Contributor Author

Waiting for the 104 release branch cut before landing.

@rocketsroger rocketsroger requested a review from a team July 22, 2022 19:55
@rocketsroger rocketsroger removed the do not land PRs that requires coordination before landing label Jul 26, 2022
csadilek
csadilek approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for talking through yesterday and making the changes we discussed!

👍

Let's land on Monday :)

@rocketsroger
Copy link
Contributor Author

Thanks for talking through yesterday and making the changes we discussed!

👍

Let's land on Monday :)

Agreed. I'll land this on Monday.

@rocketsroger rocketsroger added do not land PRs that requires coordination before landing 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed do not land PRs that requires coordination before landing labels Jul 29, 2022
@mergify mergify bot merged commit eb56ea1 into mozilla-mobile:main Aug 3, 2022
@rocketsroger rocketsroger deleted the AC_12538 branch August 3, 2022 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarah541 sarah541 sarah541 left review comments

@csadilek csadilek csadilek approved these changes

Assignees

@csadilek csadilek

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash notification will always trigger the crash prompt dialog
3 participants
@rocketsroger @csadilek @sarah541