Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #11890: Add a new action container in the EditToolbar #11891

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Issue #11890: Add a new action container in the EditToolbar #11891

merged 1 commit into from
Mar 24, 2022

Conversation

gabrielluong
Copy link
Member

Fixes #11890

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@gabrielluong gabrielluong added the work in progress Not ready to land yet. Work in progress (WIP). label Mar 18, 2022
@gabrielluong gabrielluong force-pushed the 11890 branch 2 times, most recently from 5f8392f to a379584 Compare March 19, 2022 03:46
@gabrielluong gabrielluong marked this pull request as ready for review March 19, 2022 03:46
@gabrielluong gabrielluong requested review from a team and jonalmeida as code owners March 19, 2022 03:46
@gabrielluong gabrielluong added 🕵️‍♀️ needs review PRs that need to be reviewed work in progress Not ready to land yet. Work in progress (WIP). and removed work in progress Not ready to land yet. Work in progress (WIP). 🕵️‍♀️ needs review PRs that need to be reviewed labels Mar 19, 2022
rocketsroger
rocketsroger approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rocketsroger rocketsroger self-requested a review March 22, 2022 13:52
@gabrielluong gabrielluong removed the work in progress Not ready to land yet. Work in progress (WIP). label Mar 22, 2022
@gabrielluong gabrielluong requested a review from jonalmeida March 22, 2022 14:48
@gabrielluong gabrielluong added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 22, 2022
jonalmeida
jonalmeida approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for Roger's review as well.

@gabrielluong gabrielluong added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Mar 24, 2022
@mergify mergify bot merged commit 1ed389d into mozilla-mobile:main Mar 24, 2022
@gabrielluong gabrielluong deleted the 11890 branch March 24, 2022 20:27
@csadilek csadilek mentioned this pull request Mar 24, 2022
Merged
@gabrielluong gabrielluong mentioned this pull request Mar 30, 2022
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rocketsroger rocketsroger rocketsroger approved these changes

@jonalmeida jonalmeida jonalmeida approved these changes

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new action container in the EditToolbar
3 participants
@gabrielluong @jonalmeida @rocketsroger