Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stomp: Fix passing different types to std::min in cost_functions.hpp #3244

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 14, 2025

Description

std::min supports comparing scalar of the same type. Depending on the specific platform or compiler, values.cols() return type may not be compatible with long, so explicitly casting ensure that std::min compiles fine on any platform.

Specifically, I had encountered a compilation problem with this when compiling moveit with MSVC 2019.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@JafarAbdi JafarAbdi enabled auto-merge January 14, 2025 14:08
@JafarAbdi JafarAbdi added this pull request to the merge queue Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.64%. Comparing base (b5eb4de) to head (9eef663).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
- Coverage   45.66%   45.64%   -0.02%     
==========================================
  Files         714      714              
  Lines       62296    62298       +2     
  Branches     7531     7529       -2     
==========================================
- Hits        28442    28427      -15     
- Misses      33688    33705      +17     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into moveit:main with commit 415a4a2 Jan 14, 2025
9 checks passed
@sea-bass sea-bass added the backport-jazzy Mergify label that triggers a PR backport to Jazzy label Jan 14, 2025
mergify bot pushed a commit that referenced this pull request Jan 14, 2025
sea-bass pushed a commit that referenced this pull request Jan 14, 2025
…#3245)

(cherry picked from commit 415a4a2)

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants