-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode encoding in import errors - Fix for issue #346 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoding unicode to ascii with replace if Python 2 before casting it to string to avoid UnicodeDecodeError
encoding unicode to ascii in warn_import_error
houndci-bot
reviewed
Jul 8, 2021
Added definition of unicode for Python 3 as Hound was flagging it otherwise. (Change doesn't do anything in Python 3 otherwise).
This looks good, thanks for this. Now, can you think of any way to actually test this? :S Ideally, we'd run it on a non-English OS, but in the context of Travis I'm not sure how to do that.. Also, I just noticed Travis isn't even being called! Investingating.. |
There we go, looks like there's another complaint regarding the unicode variable. |
Looks good, let's give it a try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Python 2, and import error message is unicode, encode as ascii before casting to string to avoid UnicodeDecodeError.
Fix for #346
Typical example of error message that triggers a UnicodeDecodeError:
Typical use case where this happens:
Isolated behavior: