Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NonTransfer proxy filter #3141

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Update NonTransfer proxy filter #3141

merged 1 commit into from
Jan 20, 2025

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Jan 20, 2025

⚠️ Breaking Changes ⚠️

Identity calls add_sub and set_subs will no longer be callable from a NonTransfer proxy.

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Jan 20, 2025
@RomarQ RomarQ requested a review from stiiifff January 20, 2025 11:27
@RomarQ RomarQ self-assigned this Jan 20, 2025
Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2272 KB (no changes) ✅

Moonbeam runtime: 2252 KB (no changes) ✅

Moonriver runtime: 2244 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2272 KB (+244 KB compared to latest release) ⚠️

Moonbeam runtime: 2252 KB (+240 KB compared to latest release) ⚠️

Moonriver runtime: 2244 KB (+232 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                     Coverage Diff                      @@
##           master   rq/update-identity-proxy      +/-   ##
============================================================
- Coverage   74.59%                     74.58%   -0.01%     
  Files         377                        377              
+ Lines       96033                      96042       +9     
============================================================
  Hits        71632                      71632              
+ Misses      24401                      24410       +9     
Files Changed Coverage
/runtime/moonbase/src/lib.rs 50.34% (-0.26%) 🔽
/runtime/moonbeam/src/lib.rs 44.43% (-0.22%) 🔽
/runtime/moonriver/src/lib.rs 44.65% (-0.22%) 🔽

Coverage generated Mon Jan 20 12:00:31 UTC 2025

@RomarQ RomarQ requested a review from manuelmauro January 20, 2025 12:16
@RomarQ RomarQ merged commit 4f01eda into master Jan 20, 2025
47 checks passed
@RomarQ RomarQ deleted the rq/update-identity-proxy branch January 20, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants