Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audit log for contact description #3582

Merged
merged 5 commits into from
Feb 14, 2020

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Feb 14, 2020

This PR adds audit logs for the SetDescription and ClearDescription services.

@djaiss
Copy link
Member Author

djaiss commented Feb 14, 2020

@asbiin this is what I've done tonight. It also tests that the job for creating audit logs has been dispatched.

@djaiss djaiss changed the title 2020 02 13 audit description feat: add audit log for contact description Feb 14, 2020
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

90.3% 90.3% Coverage
60.2% 60.2% Duplication

@djaiss djaiss merged commit 4863b92 into master Feb 14, 2020
@djaiss djaiss deleted the 2020-02-13-audit-description branch February 14, 2020 02:27
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant