Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: activity seeder to use new schema #3503

Merged
merged 3 commits into from
Jan 25, 2020
Merged

fix: activity seeder to use new schema #3503

merged 3 commits into from
Jan 25, 2020

Conversation

mechanarchy
Copy link

The activity seeder got broken in commit 3e007af recently:

'happened_at' => 'required|date|date_format:Y-m-d',
'emotions' => 'nullable|array',
'contacts' => 'required|array',

vs
$request = [
'account_id' => $this->contact->account_id,
'activity_type_id' => rand(1, 13),
'summary' => $this->faker->realText(rand(40, 100)),
'description' => (rand(1, 2) == 1 ? $this->faker->realText(rand(100, 1000)) : null),
'date' => $date,
];

This PR fixes it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asbiin asbiin merged commit 1543da2 into monicahq:master Jan 25, 2020
@asbiin
Copy link
Member

asbiin commented Jan 25, 2020

thank you @mechanarchy

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants