Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: associate a photo to a gift #3342

Merged
merged 27 commits into from
Jan 4, 2020
Merged

feat: associate a photo to a gift #3342

merged 27 commits into from
Jan 4, 2020

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Dec 22, 2019

This close #3098

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the FakeContentTableSeeder is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.

@asbiin asbiin marked this pull request as ready for review December 23, 2019 10:27
@djaiss
Copy link
Member

djaiss commented Dec 23, 2019

It looks great!! Good job @asbiin

@djaiss
Copy link
Member

djaiss commented Dec 23, 2019

Beware - the GenerateDummyData script does not work with this branch anymore. You need to update it as well.

@djaiss djaiss mentioned this pull request Dec 28, 2019
@asbiin asbiin requested a review from djaiss December 30, 2019 23:33
@asbiin
Copy link
Member Author

asbiin commented Dec 30, 2019

@djaiss a lot of changes has been made, I think the UX is now ok, can you test it please?

Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, super job!

@djaiss
Copy link
Member

djaiss commented Jan 4, 2020

Great for me 😀 Good job man!

@asbiin asbiin merged commit 56bfde7 into master Jan 4, 2020
@asbiin asbiin deleted the feat/gift-photo-2019-12-22 branch January 4, 2020 19:24
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding images to gift ideas
2 participants