Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order contact tag list alphabetically #3243

Merged
merged 7 commits into from
Feb 2, 2020
Merged

fix: order contact tag list alphabetically #3243

merged 7 commits into from
Feb 2, 2020

Conversation

mechanarchy
Copy link

The list of applied contact tags on the Contacts list is currently unsorted:
image

This can make it quite difficult to locate and align related tags (eg Work - Job1, Work - Job2). This PR will sort the list of tags alphabetically:
image

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!
Thus, it will not work with non-ascii character and you should not use the orderBy method for that.

@mechanarchy mechanarchy requested a review from asbiin January 24, 2020 12:46
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 67bbf3b into monicahq:master Feb 2, 2020
@asbiin
Copy link
Member

asbiin commented Feb 2, 2020

Thank you @mechanarchy

@mechanarchy mechanarchy deleted the sort-contact-tags-by-name branch February 3, 2020 10:22
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants