-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow editing middle name #3218
feat: Allow editing middle name #3218
Conversation
Ivan@Kruchkoff.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Addresses #511 |
…ure/511-edit-middle-name
Hi @asbiin any tips for getting this reviewed/merged? |
@ivankruchkoff thank you for your time and fix. |
@ivankruchkoff I've added the test, it's ok now! Should you sign the CLA please? |
@asbiin I've signed the CLA, but it just redirects me back to this PR without updating the status I confirm that: I have the legal authority to enter into this Agreement. |
Please get this in! Got some vcard imports that are showing up wrong without it. |
Merged latest master branch cc @asbiin |
Kudos, SonarCloud Quality Gate passed!
|
Kudos, SonarCloud Quality Gate passed!
|
@ivankruchkoff thank you for your help! |
This pull request has been automatically locked since there |
First of all thanks so much for taking the time to open a pull request and help the project. It's because of people like you that we love working on this project.
Please read the list below. Feel free to delete this text after but we need you to read it so we make sure that the project is consistent and remains of quality.
Checklist
Before submitting the PR
[wip]
in the title of the PR it is is not final yet. Remove[wip]
when ready. Otherwise the PR will be considered complete and rejected if it's not working.General checks
Front-end changes
Backend/models changes
If the code changes the SQL schema
vCard
and.csv
files.Other tasks
UNRELEASED
.