Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow editing middle name #3218

Merged
merged 11 commits into from
Mar 1, 2020

Conversation

ivankruchkoff
Copy link

@ivankruchkoff ivankruchkoff commented Nov 17, 2019

First of all thanks so much for taking the time to open a pull request and help the project. It's because of people like you that we love working on this project.

Please read the list below. Feel free to delete this text after but we need you to read it so we make sure that the project is consistent and remains of quality.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging @djaiss or @asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the FakeContentTableSeeder is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ivan@Kruchkoff.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ivankruchkoff
Copy link
Author

Addresses #511

@ivankruchkoff
Copy link
Author

ivankruchkoff commented Nov 17, 2019

Added field in contact:
/people/add

Screenshot 2019-11-17 11 27 21

/people/add when Last Name first
Screenshot 2019-11-17 11 37 24

/people/h:HASHID/edit
Screenshot 2019-11-17 11 17 37

@ivankruchkoff ivankruchkoff changed the title Allow editing middle name #511 feat: Allow editing middle name Nov 17, 2019
@ivankruchkoff
Copy link
Author

Hi @asbiin any tips for getting this reviewed/merged?

@asbiin
Copy link
Member

asbiin commented Dec 16, 2019

@ivankruchkoff thank you for your time and fix.
Here you need to add some test to address the minimum code coverage (60%). But the function should already have been covered!

@asbiin
Copy link
Member

asbiin commented Dec 16, 2019

@ivankruchkoff I've added the test, it's ok now! Should you sign the CLA please?

@ivankruchkoff
Copy link
Author

@asbiin I've signed the CLA, but it just redirects me back to this PR without updating the status

Screenshot 2020-01-02 14 50 47

I confirm that:

I have the legal authority to enter into this Agreement.
My contribution is either your original creation, based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and you have the right under that license to submit that work with modifications, whether created in whole or in part by you, or you have clearly identified the source of the contribution and any license or other restriction (like related patents, trademarks, and license agreements) of which you are personally aware.
The grant of rights under Section 2 does not violate any grant of rights which I have made to third parties, including my employer.
I submit to /~https://github.com/monicahq/monica/blob/master/CODE_OF_CONDUCT.md

@cayblood
Copy link

Please get this in! Got some vcard imports that are showing up wrong without it.

@ivankruchkoff
Copy link
Author

Merged latest master branch cc @asbiin

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 7d50381 into monicahq:master Mar 1, 2020
@asbiin
Copy link
Member

asbiin commented Mar 1, 2020

@ivankruchkoff thank you for your help!

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants