Add equals operator to Atlas Search #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
katcharov
reviewed
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Show resolved
Hide resolved
katcharov
reviewed
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Show resolved
Hide resolved
katcharov
reviewed
Jan 16, 2025
| } | ||
|
|
||
| /** | ||
| * Returns a {@link SearchOperator} that checks whether a field matches a value you specify. |
There was a problem hiding this comment.
The docs from our docs page are confusing. I think we should say, ...that searches for documents where a field matches the specified value. in all of these
stIncMale
reviewed
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Show resolved
Hide resolved
4 tasks
# Conflicts: # driver-core/src/main/com/mongodb/client/model/search/SearchConstructibleBsonElement.java # driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java # driver-core/src/test/functional/com/mongodb/client/model/search/AggregatesSearchIntegrationTest.java # driver-core/src/test/unit/com/mongodb/client/model/search/SearchOperatorTest.java # driver-scala/src/main/scala/org/mongodb/scala/model/search/SearchOperator.scala # driver-scala/src/main/scala/org/mongodb/scala/model/search/package.scala
|
I reviewed the commits before that commit. |
rozza
pushed a commit
that referenced
this pull request
Feb 6, 2025
JAVA-5729 --------- Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
JAVA-5729
Description
There are several Atlas Search query operators that are not implemented with first class support in the Java driver. This PR adds the
equalsoperator to Atlas Search.Testing
./gradlew checkatlas-search-teston EvergreenSearchOperatorTest