Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ParticleTrackFile.write_shapefile): check for "k" even if "i", "j are not present #2294

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

jlarsen-usgs
Copy link
Contributor

  • "k", "node" output present with mp7 pathline and timeseries

* force remapping to be calculated from iac, ja array
* add 0 digit padding to file names
* update UnstructuredGrid, add cell2d input parameter and property method
* add clean_iverts() to UnstructuredGrid to remove duplicated vertex and invert information
* update testing for new features
…" are not present

* "k", "node" output present with mp7 pathline and timeseries
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.8%. Comparing base (b747803) to head (5cc292d).
Report is 3 commits behind head on develop.

Files Patch % Lines
flopy/utils/particletrackfile.py 0.0% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #2294      +/-   ##
==========================================
- Coverage     76.0%   35.8%   -40.2%     
==========================================
  Files          294     294              
  Lines        59396   59340      -56     
==========================================
- Hits         45166   21278   -23888     
- Misses       14230   38062   +23832     
Files Coverage Δ
flopy/utils/particletrackfile.py 20.7% <0.0%> (-75.3%) ⬇️

... and 159 files with indirect coverage changes

@jlarsen-usgs jlarsen-usgs merged commit f86881d into modflowpy:develop Aug 17, 2024
26 checks passed
@wpbonelli wpbonelli modified the milestones: 3.9, 3.8.1 Sep 4, 2024
martclanor pushed a commit to martclanor/flopy that referenced this pull request Sep 21, 2024
…j are not present (modflowpy#2294)

* fix for "k", "node" output present with mp7 pathline and timeseries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants