drop legacy Go support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 60.42% 65.29% +4.86%
==========================================
Files 20 19 -1
Lines 753 533 -220
==========================================
- Hits 455 348 -107
+ Misses 282 172 -110
+ Partials 16 13 -3
Continue to review full report at Codecov.
|
|
any comments? |
Go 1.9 was released in August 2017 so it's safe to make a claim that projects are already using new enough Go version. Tested with: $ go version go version go1.13.8 linux/amd64 $ GO111MODULE=off ./test.sh ok github.com/modern-go/reflect2-tests 0.005s coverage: 12.3% of statements in github.com/modern-go/reflect2 ok github.com/modern-go/reflect2-tests/test15 0.004s coverage: 6.4% of statements in github.com/modern-go/reflect2 ok github.com/modern-go/reflect2-tests/tests 0.010s coverage: 65.4% of statements in github.com/modern-go/reflect2 Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
|
rebased to resolve conflicts, force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.9 was released in August 2017 so it's safe to make a claim that projects
are already using new enough Go version.
Tested with:
Signed-off-by: Mikko Ylinen mikko.ylinen@intel.com