Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone to clock widget #74

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

Dambakk
Copy link

@Dambakk Dambakk commented Mar 31, 2019

My company has servers across the world and we would like to see the time at these places. The clock widget could easily be extended to show the time in a specific timezone using zones defined in the tz database.

Tested in Chrome and Firefox on Windows and Linux.

@Dambakk
Copy link
Author

Dambakk commented Mar 31, 2019

Preview:

screenshot_clock_widget

@Dambakk
Copy link
Author

Dambakk commented Oct 2, 2019

What is the status on this PR? Will it be reviewed and merged anytime soon? @dnsmichi

@dnsmichi
Copy link
Collaborator

dnsmichi commented Oct 2, 2019

I'm on vacation, I'll look into this in the coming weeks.

@dnsmichi
Copy link
Collaborator

dnsmichi commented Oct 8, 2019

Due to the en_US locale, the time is not in full format. Looks a bit different than your screenshot.

Screen Shot 2019-10-08 at 17 04 52

@dnsmichi
Copy link
Collaborator

dnsmichi commented Oct 8, 2019

I see. That needs some coffeescript adjustments and a slight change in formatting.
https://reviewco.de/frage/date-objekt-in-coffeescript-in-string-konvertieren-mit-einem-seltsamen-format

@dnsmichi dnsmichi added this to the 2.1.0 milestone Oct 8, 2019
@dnsmichi dnsmichi merged commit 99d1d00 into mocdaniel:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants