log: mark grpc messages with module #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LK4D4
suggested changes
Nov 30, 2016
| @@ -1,8 +1,14 @@ | |||
| package log | |||
|
|
|||
| import "google.golang.org/grpc/grpclog" | |||
| import ( | |||
| "context" | |||
There was a problem hiding this comment.
should be golang.org/x/net/context
Current coverage is 54.97% (diff: 100%)@@ master #1778 diff @@
==========================================
Files 102 102
Lines 16875 16876 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 9297 9278 -19
- Misses 6425 6440 +15
- Partials 1153 1158 +5
|
Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
grpc-module
branch
from
9d169db to
c7e6b13
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day stephen.day@docker.com
cc @aaronlehmann @aluzzardi