Expose dockerui context detection functions as public #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
approved these changes
Apr 3, 2023
Buildx uses these functions, so it makes sense to expose these so that we don't re-implement them and cause drift over time (which we have already done). Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
public-detect-context-funcs
branch
from
78c0f8d to
f17630e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildx uses these functions, so it makes sense to expose these so that we don't re-implement them and cause drift over time (which we have already done).
See docker/buildx#1710 (comment):