Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propogate image-resolve-mode for SBOM generator image #3446

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Jan 3, 2023

I discovered that updates to the :edge tag for buildkit-syft-scanner weren't re-running the scanner, even though we had a new image.

To enable this behavior, we need to pass through the value of the image-resolve-mode parameter, similar to how we do for the no-cache parameter.

@jedevc jedevc requested a review from tonistiigi January 3, 2023 16:09
@tonistiigi
Copy link
Member

I discovered that updates to the :edge tag for buildkit-syft-scanner weren't re-running the scanner,

You mean when you had image with the same name in docker images or in what case it didn't work? Picking up tag updates should be the default with no extra config needed.

@jedevc
Copy link
Member Author

jedevc commented Jan 4, 2023

Picking up tag updates should be the default with no extra config needed.

Indeed - this looks possibly related to another issue, I need to investigate a bit further. The image-resolve-mode parameter doesn't seem related.

@jedevc
Copy link
Member Author

jedevc commented Jan 6, 2023

Looks like the related issue was related to #3454, which looked like it caused some weirdness with builds using cache, and --no-cache being processed simultaneously. Weird, but definitely not related to this, we should be fine to merge this PR.

@jedevc jedevc force-pushed the sbom-image-resolve-mode branch from 0247619 to b23d823 Compare May 23, 2023 13:57
@jedevc
Copy link
Member Author

jedevc commented May 23, 2023

Hm, this should have probably made it for v0.11, but didn't. I'm gonna milestone this for v0.12, not an urgent one, but image-resolve-mode should apply for the SBOM generation image.

@jedevc jedevc added this to the v0.12.0 milestone May 23, 2023
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedevc Needs rebase

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the sbom-image-resolve-mode branch from b23d823 to a609d2e Compare June 28, 2023 10:23
@tonistiigi tonistiigi merged commit 12070ca into moby:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants