Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Warn if attempting to modify comp.render after MobX has attached #799

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Warn if attempting to modify comp.render after MobX has attached #799

merged 2 commits into from
Jan 12, 2020

Conversation

Venryx
Copy link
Contributor

@Venryx Venryx commented Nov 12, 2019

@Venryx
* Added warning for attempting to modify a component class' render fu…
edb5779 
…nction after a MobX reaction has already attached. Helps prevent memory leaks as in: [mobxjs#797](mobxjs#797)

* Added test for the above.
* Added changelog entry.
@Venryx Venryx mentioned this pull request Nov 12, 2019
Closed
@danielkcz
Copy link
Contributor

Please, make it DEV only check.

@Venryx
Copy link
Contributor Author

Venryx commented Nov 12, 2019 •
edited
Loading

Please, make it DEV only check.

Done.

@mweststrate mweststrate merged commit 9850df8 into mobxjs:master Jan 12, 2020
@mweststrate
Copy link
Member

Great stuff, thanks!

@github-actions github-actions bot mentioned this pull request Oct 13, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielkcz danielkcz danielkcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component-class with @observer doesn't dispose reaction if render() is hot-swapped
3 participants
@Venryx @danielkcz @mweststrate