Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Make isObjectShallowModified treat NaN equal to NaN #402

Merged
merged 3 commits into from
Feb 1, 2018
Merged

Make isObjectShallowModified treat NaN equal to NaN #402

merged 3 commits into from
Feb 1, 2018

Conversation

andrewbranch
Copy link
Contributor

Sorry for the delay!

Fixes #363

@mweststrate mweststrate merged commit 65437a7 into mobxjs:master Feb 1, 2018
@mweststrate
Copy link
Member

Thanks for the PR.

Note that some of the tests where failing in this branch, because the isNaN check was not correct (cause isNaN({}) === true).

Next time make sure all tests pass :)

Merged now manually

@andrewbranch
Copy link
Contributor Author

andrewbranch commented Feb 1, 2018

@mweststrate woops, thanks for fixing. For what it's worth, I was unable to get the full test suite running locally. The Electron shell would boot up, but then everything just hangs. I could run individual tests with the Jest plugin for VS Code. I'm on Node 7.10.0. Maybe worth looking into for the sake of other future contributors?

@andrewbranch andrewbranch deleted the is-object-shallow-modified-NaN branch February 1, 2018 19:00
@mweststrate
Copy link
Member

mweststrate commented Feb 1, 2018 via email

@github-actions github-actions bot mentioned this pull request Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants