Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: use tools.mod for tools install #61

Merged
merged 5 commits into from
Mar 19, 2021
Merged

script: use tools.mod for tools install #61

merged 5 commits into from
Mar 19, 2021

Conversation

mmcloughlin
Copy link
Owner

@mmcloughlin mmcloughlin commented Mar 19, 2021

The stress test CI job has been failing due to an error in bootstrap:

/~https://github.com/mmcloughlin/addchain/runs/2129921772?check_suite_focus=true#step:5:24

The problem relates to gobin under Go 1.16 myitcv/gobin#103.

This PR fixes the issue by using a tools.mod file to manage tools dependencies as suggested in:

https://www.bwplotka.dev/2020/bingo/
/~https://github.com/prometheus-operator/prometheus-operator/blob/5a2412883718ffe889fe741d5e0e5e7ae6b5f183/scripts/go.mod

@codecov-io
Copy link

codecov-io commented Mar 19, 2021

Codecov Report

Merging #61 (9f09bf6) into master (6fcb85f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   76.32%   76.32%           
=======================================
  Files          25       25           
  Lines         997      997           
=======================================
  Hits          761      761           
  Misses        189      189           
  Partials       47       47           
Flag Coverage Δ
unittests 76.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fcb85f...9f09bf6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants