Allow configuring multiple routes that point to different endpoints #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
force-pushed
the
mfn-multi-route
branch
2 times, most recently
from
c290104 to
a61f741
Compare
spawnia
requested changes
Apr 13, 2023
mfn
force-pushed
the
mfn-multi-route
branch
2 times, most recently
from
50a38c2 to
c92c810
Compare
spawnia
reviewed
Apr 13, 2023
Instead of a single route definition, multiple routes can be defined. They "key" is the URI name and necessary for the controller to look up the config for e.g. the endpoint.
spawnia
changed the title
|
Thanks for merging and also putting in some final touches! Already tried in a private project, all working so far 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of a single route definition, multiple routes can be defined.
They "key" is the URI name and necessary for the controller to look up the config for e.g. the endpoint.
The diff is pretty wild, it's best viewed with disabling whitespace.
This is obviously a major breakage and would require a new major version 😬
Notes
Before making the PR I verified the feasibility by modifying vendor files in a private project using rebing/graphql-laravel to achieve the desired effect.
TODO
Some parts are already outdated but in general a few more pieces should be adjusted.
Links