Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add automountServiceAccountToken to helm chart #202

Merged
merged 2 commits into from
Aug 1, 2022
Merged

add automountServiceAccountToken to helm chart #202

merged 2 commits into from
Aug 1, 2022

Conversation

guethb
Copy link
Contributor

@guethb guethb commented Jul 4, 2022

We need the automountServiceAccountToken option for deployment and serviceAccount in k8s. Please consider this pull request, adding these entries to kubernetes-replicator helm chart.

@guethb
Copy link
Contributor Author

guethb commented Jul 7, 2022

Hello!
Could you please check, if you want to add this feature and leave me some feedback concerning your decision?
With best regards!
bernhard

@guethb guethb requested a review from martin-helmich July 14, 2022 08:15
@mittwald-machine
Copy link
Collaborator

There has not been any activity to this pull request in the last 14 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

@guethb
Copy link
Contributor Author

guethb commented Aug 1, 2022

Please remove stale label.

@guethb
Copy link
Contributor Author

guethb commented Aug 1, 2022

@martin-helmich I made the changes you requested. Could you please review them and remove the stale label from my PR?

Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 -- thanks for your contribution.

@martin-helmich martin-helmich enabled auto-merge (squash) August 1, 2022 07:59
@martin-helmich martin-helmich merged commit 1f4db8a into mittwald:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants