Implement annotation replicator.v1.mittwald.de/strip-labels #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
force-pushed
the
strip-labels
branch
from
7ab98b5 to
0d73239
Compare
jkroepke
force-pushed
the
strip-labels
branch
from
0d73239 to
6cf126c
Compare
jkroepke
changed the title
|
Hi @hensur , if you find some time for review this, it would be great! |
hensur
requested changes
Nov 24, 2021
jkroepke
force-pushed
the
strip-labels
branch
from
7e07b4a to
19a1d18
Compare
|
Hi @hensur thanks for taking a feedback. Sorry for doing a lot of copypasta, sometime I do not have the full understanding of golang. I do a commit for each of you comments/suggestions. I hope you can quicker followup the changes that I do, to validate them. Let me know, if I should do a rebase/squash. |
hensur
approved these changes
Nov 25, 2021
|
Hey @jkroepke, Don't worry, sometimes I don't have that understanding either :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
this PR add a new feature to mittwald/kubernetes-replicator.
Motivation of this change:
Operators like /~https://github.com/strimzi/strimzi-kafka-operator implements an own garbage collection based on specific labels defined on resources. If mittwald replicator replicate secrets to different namespace, the strimzi-kafka-operator will remove the replicated secrets because from operators point of view the secret is a left-over. To mitigate the issue, set the annotation replicator.v1.mittwald.de/strip-labels=true to remove all labels on the replicated resource.
Fixes #151