Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop-types are not actually removed in production #257

Closed
nolanlawson opened this issue Dec 18, 2018 · 0 comments · Fixed by #258
Closed

prop-types are not actually removed in production #257

nolanlawson opened this issue Dec 18, 2018 · 0 comments · Fixed by #258

Comments

@nolanlawson
Copy link

Currently this package is using babel-plugin-transform-react-remove-prop-types but it's not actually removing prop-types because the usage of prop-types is too subtle for the Babel transform to figure out.

Also, our usage precludes the possibility of library users from removing it themselves using this same Babel plugin.

You can reproduce this issue by running:

yarn build

Then:

egrep -r '(prop-types|shared-props)' dist dist-es

Then you'll see that there are several files importing these modules, even in the production build.

nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Dec 18, 2018
nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Dec 18, 2018
nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Mar 8, 2019
nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Mar 8, 2019
nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant