make platform truly configurable, and add arm64 where missing #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
added
build
csujedihy
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Make all the script and project files use configurable platforms, while still defaulting to x64.
Also fix a regression from #660 where ASAN accidentally stopped using ASAN, and try to detect similar CI failures in the future.
N.B. ASAN is not yet supported for arm64 in Visual Studio, so exclude that project's arm64 platform from the solution.
Testing
Do any existing tests cover this change? Are new tests needed?
CI.
Documentation
Is there any documentation impact for this change?
Nope. We still don't build/test/support arm64.
Installation
Is there any installer impact for this change?
No.